From 064e82c1b36bfdef47a5bcbbbf7757c7b9adea91 Mon Sep 17 00:00:00 2001 From: Vivien Maisonneuve Date: Tue, 19 Aug 2014 14:58:23 +0200 Subject: [PATCH 1/1] Return NotImplemented in Point special methods --- linpy/geometry.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/linpy/geometry.py b/linpy/geometry.py index 5b5ed89..a0a7b7c 100644 --- a/linpy/geometry.py +++ b/linpy/geometry.py @@ -185,10 +185,10 @@ class Point(Coordinates, GeometricObject): """ Translate the point by a Vector object and return the resulting point. """ - if not isinstance(other, Vector): - return NotImplemented - coordinates = self._map2(other, operator.add) - return Point(coordinates) + if isinstance(other, Vector): + coordinates = self._map2(other, operator.add) + return Point(coordinates) + return NotImplemented def __sub__(self, other): """ @@ -203,15 +203,15 @@ class Point(Coordinates, GeometricObject): elif isinstance(other, Vector): coordinates = self._map2(other, operator.sub) return Point(coordinates) - else: - return NotImplemented + return NotImplemented def __eq__(self, other): """ Test whether two points are equal. """ - return isinstance(other, Point) and \ - self._coordinates == other._coordinates + if isinstance(other, Point): + return self._coordinates == other._coordinates + return NotImplemented def aspolyhedron(self): from .polyhedra import Polyhedron -- 2.20.1